Integrated: 8289710: Move Suspend/Resume classes out of os.hpp

Ioi Lam iklam at openjdk.org
Fri Jul 8 05:42:32 UTC 2022


On Mon, 4 Jul 2022 23:07:27 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Please review this simple change that only renames a few classes and moved some code around. No functional changes.
> 
> The following classes are used only sparingly. They should be moved to a new header file share/runtime/suspend.hpp to minimize the size of os.hpp
> 
> - SuspendedThreadTaskContext
> - SuspendedThreadTask
> - SuspendResume
> 
> I didn't move the OS-specific implementation to a new file -- the POSIX implementation is currently inside [signals_posix.cpp](https://github.com/openjdk/jdk/blob/df063f7db18a40ea7325fe608b3206a6dff812c1/src/hotspot/os/posix/signals_posix.cpp#L1790) mixed with other signal handling code, so it doesn't seem a good idea to move out just the code for the above 3 classes.
> 
> The only other implementation is in os_windows.cpp. I could move the code to suspend_windows.cpp, but I don't feel very motivated unless someone insists.

This pull request has now been integrated.

Changeset: 1fec62f2
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1fec62f299294a0c3b3c639883cdcdc8f1410224
Stats:     379 lines in 14 files changed: 229 ins; 114 del; 36 mod

8289710: Move Suspend/Resume classes out of os.hpp

Reviewed-by: dholmes, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/9371


More information about the hotspot-dev mailing list