RFR: 8265473: Move os::Linux to its own header file [v3]

Coleen Phillimore coleenp at openjdk.org
Fri Jul 8 18:51:43 UTC 2022


On Fri, 8 Jul 2022 18:16:35 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Another step of moving unnecessary stuff outside of os.hpp
>> 
>> The `os::Linux` class is used only by the Linux-specific code in HotSpot. Therefore, it should be moved outside of os.hpp, which is used by platform-independent code.
>> 
>> I don't have a good name for the new header. `os_linux.hpp` would have been a good name, but that's already taken, so I am settling on os_linux.impl.hpp. Suggestions are welcome.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed other linux variants

This seems fine.  The name could be os_linux_impl.hpp, since impl looks a lot like inline surrounded by dots.
os_share_linux.hpp should be deleted if it's not used.  I wouldn't think of looking there for anything.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9423


More information about the hotspot-dev mailing list