RFR: 8290027: Move inline functions from vm_version_x86.hpp to cpp [v2]

Ioi Lam iklam at openjdk.org
Mon Jul 11 03:14:51 UTC 2022


> There are several large inline functions in vm_version_x86.hpp that are used only by vm_version_x86.cpp. E.g., `feature_flags()`
> 
> These should be moved to vm_version_x86.cpp to improve C++ build speed.
> 
> I manually diff'ed the lines that were moved between the two files. They were identical except for whitespaces.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into 8290027-move-unnecessary-inline-funcs-vm-version-x86
 - 8290027: Move inline functions from vm_version_x86.hpp to cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9431/files
  - new: https://git.openjdk.org/jdk/pull/9431/files/9ff42ede..9b38dce8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9431&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9431&range=00-01

  Stats: 1095 lines in 53 files changed: 737 ins; 149 del; 209 mod
  Patch: https://git.openjdk.org/jdk/pull/9431.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9431/head:pull/9431

PR: https://git.openjdk.org/jdk/pull/9431


More information about the hotspot-dev mailing list