RFR: 8265473: Move os::Linux to its own header file [v4]
Ioi Lam
iklam at openjdk.org
Mon Jul 11 05:27:39 UTC 2022
On Sat, 9 Jul 2022 23:27:31 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Another step of moving unnecessary stuff outside of os.hpp
>>
>> The `os::Linux` class is used only by the Linux-specific code in HotSpot. Therefore, it should be moved outside of os.hpp, which is used by platform-independent code.
>>
>> I don't have a good name for the new header. `os_linux.hpp` would have been a good name, but that's already taken, so I am settling on os_linux.impl.hpp. Suggestions are welcome.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> renamed to os_linux_impl.hpp
I like the idea of using namespaces. I think the private methods in os.hpp can be moved to share/runtime/osImpl.hpp, which should be included only by the os*.cpp files. Let me try to do a prototype of this.
-------------
PR: https://git.openjdk.org/jdk/pull/9423
More information about the hotspot-dev
mailing list