RFR: 8265473: Move os::Linux to its own header file [v4]

Thomas Stuefe stuefe at openjdk.org
Mon Jul 11 09:29:43 UTC 2022


On Mon, 11 Jul 2022 08:01:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > * I don't _want_ access control for members in a public interface. A public interface should be clean and minimal. Allowing private members in an interface tempts devs into adding private implementation details, which have no place in a public header.
> 
> You are basically arguing against C++ class-based design there. C++ classes define both the public and non-public interfaces of a class. Header files include the full class definition. Ergo public header files have private implementation details.

No, I'm fine with C++ class based design. But AllStatic is just a way to group a bunch of global functions together. That has nothing to do with class-based design, these classes are never instantiated. That is just name scoping. Could have done the same with a common prefix.

-------------

PR: https://git.openjdk.org/jdk/pull/9423


More information about the hotspot-dev mailing list