RFR: 8289743: AArch64: Clean up patching logic

[Andrew Haley]

On Sun, 10 Jul 2022 23:16:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

> There are failures in tier1, 2 and 3 (ZGC use is in tier3). Most failures on Macos.
> 
> Failing tests:
> 
> compiler/codecache/stress/RandomAllocationTest.java compiler/codegen/TestOopCmp.java compiler/unsafe/UnsafeGetConstantField.java runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java#id4

Got it. This is a corner case, triggered when we have a reloc of the form `adrp; movk; add` or `adrp; movk, {ld,st}r[reg, #ofs]`.
It's a pre-existing bug which never has had any effect because this form is only ever used when the target is a fixed address. The assertion is new.

I'm running tier1 again now on MacOS.

-------------

PR: https://git.openjdk.org/jdk/pull/9398