RFR: 8289743: AArch64: Clean up patching logic [v2]

Andrew Dinn adinn at openjdk.org
Tue Jul 12 11:57:46 UTC 2022


On Mon, 11 Jul 2022 16:33:50 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> The current logic for patching is a mess of if-then-elses. By rearranging the logic and using a switch we can make it both easier to understand and faster.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8289743: AArch64: Clean up patching logic

src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 311:

> 309:     }
> 310:     case 0b101010: // Compare & branch (immediate)
> 311:     case 0b011010: // Conditional branch (immediate)

btw, the above two comments need swapping to match the correct bit pattern


      // ... 10___0 --> Conditional branch (immediate)
      case 0b101010:
      // ... 01___0 --> Compare & branch (immediate)
      case 0b011010:

-------------

PR: https://git.openjdk.org/jdk/pull/9398


More information about the hotspot-dev mailing list