RFR: 8289743: AArch64: Clean up patching logic [v2]

[Andrew Haley]

On Tue, 12 Jul 2022 12:10:45 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

> Well, normally I would agree. However, I'm balancing this against the problem of duplicatng some very complex decision logic. That duplication is a problem because it needs to stay the same in both occurrences if any of this ever gets changed and needs to be visibly the same to any passing programmer even when it does not get changed.

OK, I'm on it.

> Another possibility would be to have the dispatch logic simply return a unique enum value for each of the various distinguished leading instruction sub-cases and then have the retrieve and patch methods do a second switch on the returned enum value.

That's an interesting idea, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/9398