RFR: JDK-8290020 Deadlock in leakprofiler::emit_events during shutdown [v2]

[Erik Gahlin]

On Tue, 12 Jul 2022 13:23:38 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rm CrasherHald test
>
> Marked as reviewed by mgronlun (Reviewer).

> @mgronlun or @egahlin do you have any feedback on my query above?

The emergency dump was added because we could not execute Java code during JVM crash and the code to extract a recording file from a core dump was hard to maintain. 

The functionality was never meant to be triggered from Java.

One could argue the emergency dump should happen if somebody calls Runtime::halt(int), but I don't think that's what users want. Most likely they want a fast exit. If they call System.exit(int), JFR will do an ordinary dump in the shutdown hook, assuming JFR has been setup to dump on exit.

-------------

PR: https://git.openjdk.org/jdk/pull/9465