RFR: 8289743: AArch64: Clean up patching logic [v7]

Andrew Dinn adinn at openjdk.org
Fri Jul 15 14:39:59 UTC 2022


On Fri, 15 Jul 2022 13:23:00 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> The current logic for patching is a mess of if-then-elses. By rearranging the logic and using a switch we can make it both easier to understand and faster.
>
> Andrew Haley has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - 8289743: AArch64: Clean up patching logic
>  - 8289743: AArch64: Clean up patching logic
>  - 8289743: AArch64: Clean up patching logic

src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 106:

> 104: //      adr/adrp Rx imm21; movk Rx #imm16<<32; ldr/str Ry, [Rx, #offset_in_page]
> 105: //      adr/adrp Rx imm21; movk Rx #imm16<<32; add Ry, Rx, #offset_in_page
> 106: //      adr/adrp Rx imm21; movk Rx #imm16<<32

Probably worth adding a note that the patterns with 3 insns occur as targets for retrieval but not for patching.

-------------

PR: https://git.openjdk.org/jdk/pull/9398


More information about the hotspot-dev mailing list