RFR: 8289612: Change hotspot/jtreg tests to not use Thread.stop
Daniel D. Daugherty
dcubed at openjdk.org
Fri Jul 15 18:05:19 UTC 2022
On Fri, 15 Jul 2022 01:29:08 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> The tests are updated to don't use Thread.stop(). Tests whose intention is to verify async exception updated to use jvmti StopThread.
>
> test/hotspot/jtreg/vmTestbase/gc/gctests/mallocWithGC2/mallocWithGC2.java line 116:
>
>> 114:
>> 115: tArray[0].join(); // wait for the javaHeapEater Thread to finish
>> 116: tArray[1].stop(); // Once javaHeapEater is finished, stop the
>
> So without this the other thread will run for a full 3 minutes - is that a concern?
Looks like the test is using the default timeout value of 120 seconds/2 minutes.
With the usual timeoutFactor of 4 (or higher) used by Mach5, this should be
okay in that environment, but it might not be if invoked with a timeoutFactor
not set (which defaults to 1, IIRC).
-------------
PR: https://git.openjdk.org/jdk/pull/9505
More information about the hotspot-dev
mailing list