RFR: 8289612: Change hotspot/jtreg tests to not use Thread.stop [v8]
David Holmes
dholmes at openjdk.org
Mon Jul 18 01:16:36 UTC 2022
On Sun, 17 Jul 2022 22:35:30 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The tests are updated to don't use Thread.stop(). Tests whose intention is to verify async exception updated to use jvmti StopThread.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>
> u
Thanks for the library update -looks good!
A couple of minor typo "targets of opportunity" listed below.
One discussion still somewhat open.
Thanks.
test/hotspot/jtreg/runtime/Thread/AsyncExceptionOnMonitorEnter.java line 42:
> 40: private static int TEST_MODE = 0;
> 41:
> 42: public static native int stopThread(Thread thread);
This seems unused now.
test/hotspot/jtreg/runtime/Thread/AsyncExceptionTest.java line 57:
> 55: internalRun1();
> 56: } catch (ThreadDeath td) {
> 57: throw new RuntimeException("Catched ThreadDeath in run() instead of internalRun2() or internalRun1().\n"
existing: s/Catched/Caught/
test/hotspot/jtreg/runtime/Thread/AsyncExceptionTest.java line 65:
> 63:
> 64: if (receivedThreadDeathinInternal2 == false && receivedThreadDeathinInternal1 == false) {
> 65: throw new RuntimeException("Didn't catched ThreadDeath in internalRun2() nor in internalRun1().\n"
Existing: s/catched/catch/
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9505
More information about the hotspot-dev
mailing list