RFR: 8290706: Remove the support for inline contiguous allocations [v2]

Sergey Nazarkin snazarki at openjdk.org
Fri Jul 22 11:43:06 UTC 2022


On Thu, 21 Jul 2022 16:17:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the bug for rationale and link to RFC.
>> 
>> This removes the 3rd allocation path (first two being TLAB and native GC interface), that is used by Serial/Parallel when TLABs are not available. There is little sense in keeping this code, especially since it requires supporting a bunch of platform-specific assembly.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 fastdebug `tier1`
>>  - [x] Linux x86_32 fastdebug `tier1`
>>  - [x] Linux AArch64 fastdebug `tier1`
>>  - [x] Linux x86_64 Zero build
>>  - [x] Linux AArch64 cross-build (attn @theRealAph, @adinn)
>>  - [x] Linux ARM cross-build (attn @bulasevich, @snazarkin)
>>  - [x] Linux S390X cross-build (attn @backwaterred, @RealLucy)
>>  - [x] Linux PPC64 cross-build (attn @TheRealMDoerr, @reinrich)
>>  - [x] Linux RISC-V cross-build (attn @RealFYang)
>> 
>> Apart from x86 and AArch64, I only verified the cross-compilation builds pass, no other testing is done.
>> 
>> I did not touch the JVMCI interfaces, since I am not sure what is the proper protocol for JVMCI changes.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into JDK-8290706-remove-inline-contig
>  - Work

Got assert on arm-server-fastdebug:


#  Internal Error (/home/user/jdk/src/hotspot/cpu/arm/arm.ad:240), pid=24155, tid=24168
#  assert(constant_table.size() == consts_size) failed: must be: 208 == 200
#
# JRE version: OpenJDK Runtime Environment (20.0) (fastdebug build 20-internal-adhoc.user.jdk)
# Java VM: OpenJDK Server VM (fastdebug 20-internal-adhoc.user.jdk, mixed mode, g1 gc, linux-arm)
# Problematic frame:
# V  [libjvm.so+0xe2ed8]  MachConstantBaseNode::emit(CodeBuffer&, PhaseRegAlloc*) const+0x22b

-------------

PR: https://git.openjdk.org/jdk/pull/9576


More information about the hotspot-dev mailing list