RFR: 8290900: Build failure with Clang 14+ due to function warning attribute

[Kim Barrett]

On Fri, 22 Jul 2022 23:40:08 GMT, Man Cao <manc at openjdk.org> wrote:

> Hi all,
> 
> Could anyone review this change that fixes build failure with Clang 14+?
> The plan is to disable the warning attribute introduced by JDK-8214976, until https://github.com/llvm/llvm-project/issues/56519 is fixed and released.
> 
> -Man

Looks good.

Please create an OpenJDK RFE to reinstate the feature once there is a clang 
version that is known to work. 

I'm also not sure why one would even want this new attribute if it isn't
additive.  (And how do forward declarations deal with non-additive
attributes?)  If one is the provider of a library and so providing the "first"
declaration, and have decided this library function shouldn't be used any more
while still providing it for backward compatibility, well, that's what
deprecation warnings are for.  The use-case from OpenJDK is a client of a
library deciding (for whatever reasons) the client code shouldn't
(casually/normally) use this library function, so marks it accordingly when
compiling client code.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9621