RFR: 8290900: Build failure with Clang 14+ due to function warning attribute

[Kim Barrett]

On Sat, 23 Jul 2022 02:52:41 GMT, Man Cao <manc at openjdk.org> wrote:

>> Hi all,
>> 
>> Could anyone review this change that fixes build failure with Clang 14+?
>> The plan is to disable the warning attribute introduced by JDK-8214976, until https://github.com/llvm/llvm-project/issues/56519 is fixed and released.
>> 
>> -Man
>
> Thanks for the review.
> 
> Opened https://bugs.openjdk.org/browse/JDK-8290903 to reinstate the feature.
> 
>> I'm also not sure why one would even want this new attribute if it isn't additive. 
> 
> https://reviews.llvm.org/D106030 and https://github.com/ClangBuiltLinux/linux/issues/1173 might have some explanation. It seems to support some use cases in Linux kernel, so Clang issues warning/errors at compile time instead of link time.
> 
> There is also a pre-submit test failure, which looks like being investigated in https://bugs.openjdk.org/browse/JDK-8290885.

@caoman - as a HotSpot change, this should have had a second reviewer before being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/9621