RFR: 8290706: Remove the support for inline contiguous allocations [v2]

Erik Österlund eosterlund at openjdk.org
Mon Jul 25 08:53:48 UTC 2022


On Thu, 21 Jul 2022 16:17:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the bug for rationale and link to RFC.
>> 
>> This removes the 3rd allocation path (first two being TLAB and native GC interface), that is used by Serial/Parallel when TLABs are not available. There is little sense in keeping this code, especially since it requires supporting a bunch of platform-specific assembly.
>> 
>> Additional testing:
>>  - [x] Linux x86_64 fastdebug `tier1`
>>  - [x] Linux x86_32 fastdebug `tier1`
>>  - [x] Linux AArch64 fastdebug `tier1`
>>  - [x] Linux x86_64 Zero build
>>  - [x] Linux AArch64 cross-build (attn @theRealAph, @adinn)
>>  - [x] Linux ARM cross-build (attn @bulasevich, @snazarkin)
>>  - [x] Linux S390X cross-build (attn @backwaterred, @RealLucy)
>>  - [x] Linux PPC64 cross-build (attn @TheRealMDoerr, @reinrich)
>>  - [x] Linux RISC-V cross-build (attn @RealFYang)
>> 
>> Apart from x86 and AArch64, I only verified the cross-compilation builds pass, no other testing is done.
>> 
>> I did not touch the JVMCI interfaces, since I am not sure what is the proper protocol for JVMCI changes.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into JDK-8290706-remove-inline-contig
>  - Work

Looks good in general. However, the StorePConditionalNode is dead after this change, and I think we should remove that one as well while we are at it. AFAIK it is only used for the atomic bump pointer code. There is a whole bunch of StorePConditional matching rules in all the ad files that can be nuked, and a few mentions of Op_StorePConditional in C2 that can be removed.

-------------

Changes requested by eosterlund (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9576


More information about the hotspot-dev mailing list