RFR: 8288477: nmethod header size reduction [v3]

Boris Ulasevich bulasevich at openjdk.org
Thu Jul 28 09:33:59 UTC 2022


On Thu, 21 Jul 2022 18:24:33 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Boris Ulasevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Undo applying CompLevel where applicable. It must be a separate change
>
> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 258:
> 
>> 256:                                                                                                                                      \
>> 257:   nonstatic_field(nmethod,                     _verified_entry_point,                         address)                               \
>> 258:   nonstatic_field(nmethod,                     _comp_level,                                   int)                                   \
> 
> You should declare CompLevel in this file as well.  I think it might be missing the sanity checking that detect missing type declarations.

Hmm. Actually most of the types used in vmStructs_jvmci.cpp are not declared in VM_TYPES:
- int, intptr_t, jbyte, jint, jlong, juint, u1, u2, u4, uint, uint64_t, uintptr_t, unsigned int, void*
- AccessFlags, Annotations*, ClassLoaderData*, CollectedHeap*, CompiledMethod*, ConstMethod*, 
- JavaFrameAnchor, JavaThread*, MethodCounters*, MethodData*, ObjectWaiter*, OopHandle, OSThread*, Thread*

is it an issue?

-------------

PR: https://git.openjdk.org/jdk/pull/9165


More information about the hotspot-dev mailing list