RFR: 8287661: Fix and improve BitMap::print_on(outputStream*) [v2]

[Aleksey Shipilev]

On Wed, 1 Jun 2022 15:44:16 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8287661-bitmaps-improv
>>  - Review comments
>>  - Fix
>
> test/hotspot/gtest/utilities/test_bitMap.cpp line 107:
> 
>> 105:       map.set_bit(size / 2);
>> 106:     }
>> 107:     map.print_on(tty);
> 
> I would prefer if we didn't print to tty here. I think we should try to stay away from printing out stuff in the gtest runs. (I know that some of the tests do it).
> 
> This can be easily fixed by printing to UL:
> 
> diff --git a/test/hotspot/gtest/utilities/test_bitMap.cpp b/test/hotspot/gtest/utilities/test_bitMap.cpp
> index 7391d21ccc2..80404907e90 100644
> --- a/test/hotspot/gtest/utilities/test_bitMap.cpp
> +++ b/test/hotspot/gtest/utilities/test_bitMap.cpp
> @@ -22,6 +22,7 @@
>   */
>  
>  #include "precompiled.hpp"
> +#include "logging/logStream.hpp"
>  #include "memory/resourceArea.hpp"
>  #include "utilities/bitMap.inline.hpp"
>  #include "unittest.hpp"
> @@ -104,7 +105,9 @@ class BitMapTest {
>      if (size > 0) {
>        map.set_bit(size / 2);
>      }
> -    map.print_on(tty);
> +
> +    LogStreamHandle(Info, test) stream;
> +    map.print_on(&stream);
>    }
>  
>  #endif
> 
> 
> And if you want to see the output you can then just run with:
> 
> make test exploded-test-gtest GTEST="JAVA_OPTIONS=-Xlog:test;OPTIONS=--gtest_filter=BitMap*"

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8970