RFR: 8276789: Support C++ lambda in ResourceHashtable::iterate [v5]

[Coleen Phillimore]

On Thu, 2 Jun 2022 17:42:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> I added two new template functions to reduce the boilerplate code when walking the entries in a ResourceHashtable
>> 
>> - `template<typename F> void ResourceHashtable::iterate(F f)`
>> - `template<typename F> void ResourceHashtable::iterate_all(F f)`
>> 
>> I also modified a couple of places in systemDictionaryShared.cpp to use the new functionality.
>> 
>> Testing with tiers 1-4.
>
> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - removed empty first line
>  - Renamed DumpTimeSharedClassTable::iterate_all_live_classes() to avoid confusion with overloading

Looks good.  Thanks for the help and discussion offline. Now it makes sense.

src/hotspot/share/cds/dumpTimeClassInfo.hpp line 221:

> 219:   template<class ITER> void iterate(ITER* iter) const;
> 220:   template<typename Function> void iterate(Function function) const;
> 221:   template<typename Function> void iterate_all(Function function) const;

This helps a lot and thanks for the comment, which describes why there's a wrapper for this class.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8761