RFR: 8287830: gtest fails to compile after JDK-8287661

Aleksey Shipilev shade at openjdk.java.net
Sat Jun 4 05:50:31 UTC 2022


On Sat, 4 Jun 2022 04:54:14 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> gtest fails to compile when configured with `--with-debug-level=optimized`.
> 
> This is because for `optimized` no `PRODUCT` is defined.
> 
> ifeq ($(DEBUG_LEVEL), release)
>   # For hotspot, release builds differ internally between "optimized" and "product"
>   # in that "optimize" does not define PRODUCT.
>   ifneq ($(HOTSPOT_DEBUG_LEVEL), optimized)
>     JVM_CFLAGS_DEBUGLEVEL := -DPRODUCT
>   endif
> 
> 
> And the `test` log tag is only defined for DEBUG versions.
> 
>   LOG_TAG(table) \
>   LOG_TAG(task) \
>   DEBUG_ONLY(LOG_TAG(test)) \
>   LOG_TAG(thread) \
>   LOG_TAG(throttle) \
> 
> 
> So let's fix it.
> 
> Thanks.
> Best regards,
> Jie

Looks good and trivial, thanks.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9029


More information about the hotspot-dev mailing list