RFR: 8288051: Loom: Extend the compilation warning workaround in stack chunk copy

Coleen Phillimore coleenp at openjdk.java.net
Wed Jun 8 18:31:34 UTC 2022


On Wed, 8 Jun 2022 18:05:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Current builds fail on some newer GCCs and some arches. There is already a workaround in place in one copy method, we need the workaround in another one too. I took a brief look if we could dispense with this workaround altogether, but that does not seem to be straight-forward for JDK 19 timeframe.
> 
> 
> * For target hotspot_variant-server_libjvm_objs_continuationFreezeThaw.o:
> In file included from /home/buildbot/shipilev-jdk/src/hotspot/share/classfile/javaClasses.inline.hpp:36,
>                  from /home/buildbot/shipilev-jdk/src/hotspot/share/runtime/continuationFreezeThaw.cpp:26:
> In member function 'void stackChunkOopDesc::copy_from_stack_to_chunk(intptr_t*, intptr_t*, int)',
>     inlined from 'void FreezeBase::copy_to_chunk(intptr_t*, intptr_t*, int)' at /home/buildbot/shipilev-jdk/src/hotspot/share/runtime/continuationFreezeThaw.cpp:499:34,
>     inlined from 'freeze_result FreezeBase::recurse_freeze_stub_frame(frame&, frame&)' at /home/buildbot/shipilev-jdk/src/hotspot/share/runtime/continuationFreezeThaw.cpp:1168:16:

Looks good, and thank you for the comment.  This also appears trivial.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/9091


More information about the hotspot-dev mailing list