RFR: 8284849: Add deoptimization to unified logging [v7]

Vladimir Kozlov kvn at openjdk.java.net
Fri Jun 10 15:55:02 UTC 2022


On Thu, 9 Jun 2022 22:11:14 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Current log line:
>> 
>> `[1.334s][debug][deoptimization] cid=206 level=4 java.util.concurrent.locks.ReentrantLock$Sync::tryRelease trap_bci=26 unstable_if reinterpret pc=0x00007f89dcbf4954 relative_pc=0x0000000000000154`
>
> hi, @jdksjolen , 
> Could you update PR description example?  It looks like you have changed it to a one-liner.  just for a record in case we need to revisit this PR.  
> 
> Do you consider 'deopt' instead of 'deoptimization'? I feel deoptimization is too long as a tag.  Neither of them is a word anyway. :)

> @navyxliu, I did consider moving to `deopt` but opted against it as there are just as long tags in the rest of the set (for example "defaultmethods" and "methodcomparator").

Technically speaking it should be `uncommon_trap_deopt` because it does not cover other case of deoptimization when compiled method deoptimized due to a class change (new related class loading, unloaded, redefined) or re-compilation (from C1 to C2). That path [fetch_unroll_info()](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/deoptimization.cpp#L163) is not covered by this change (may be another RFE).

-------------

PR: https://git.openjdk.org/jdk/pull/8812


More information about the hotspot-dev mailing list