RFR: 8288105: [PPC64] Problems with -XX:+VerifyStack [v2]

[Goetz Lindenmaier]

On Fri, 10 Jun 2022 14:23:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Deoptimization and uncommon trap stubs require last Java PC to point to a PC which has an appropriate OopMap. Otherwise, -XX:+VerifyStack does no longer work after [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161).
>> I had to debug through the frame stuff and I made the code a bit more robust and easier to use and debug.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   frame::sender_for_compiled_frame: Put sender_sp and _pc into local variables as needed for the Loom port.

src/hotspot/cpu/ppc/frame_ppc.inline.hpp line 88:

> 86: 
> 87: inline frame::frame(intptr_t* sp, address pc, intptr_t* unextended_sp, intptr_t* fp, CodeBlob* cb)
> 88:   : _sp(sp), _pc(pc), _cb(nullptr), _oop_map(nullptr),

Oops, cb was never used? Good fix.

src/hotspot/cpu/ppc/frame_ppc.inline.hpp line 89:

> 87: 
> 88: inline frame::frame(intptr_t* sp) : frame(sp, nullptr) {}
> 89: 

After you added default arguments to the other constructor, why not add one for pc, too?

-------------

PR: https://git.openjdk.org/jdk19/pull/3