RFR: 8288105: [PPC64] Problems with -XX:+VerifyStack [v2]

Martin Doerr mdoerr at openjdk.java.net
Mon Jun 13 10:35:14 UTC 2022


On Mon, 13 Jun 2022 10:12:34 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/frame_ppc.inline.hpp line 89:
>> 
>>> 87: 
>>> 88: inline frame::frame(intptr_t* sp) : frame(sp, nullptr) {}
>>> 89: 
>> 
>> After you added default arguments to the other constructor, why not add one for pc, too?
>
> `explicit frame(intptr_t* sp)` is defined in shared code (frame.hpp). I don't want to add a default argument there.

But your question was good. I noticed that we should also simplify the constructor for "pns". See 3rd commit.

-------------

PR: https://git.openjdk.org/jdk19/pull/3


More information about the hotspot-dev mailing list