RFR: 8284849: Add deoptimization to unified logging [v9]

Johan Sjölén duke at openjdk.java.net
Tue Jun 14 09:08:57 UTC 2022


On Mon, 13 Jun 2022 16:12:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/deoptimization.cpp line 1841:
>> 
>>> 1839: #endif // INCLUDE_JFR
>>> 1840: 
>>> 1841: void Deoptimization::print_ul(CompiledMethod* nm, Method* tm, intptr_t pc, frame& fr, int trap_bci,
>> 
>> From what I can see, this function only called in this cpp file so it only needs to be defined only in this cpp file.  It doesn't seem to use any Deoptimization class members so doesn't need to be a class member.  Then you can revert changes to deoptimize.hpp.
>
> And can you call it something like log_deopt(), since the "print" function is generally a function that just prints to an outputStream without including logic about logging.

Sounds good, fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/8812


More information about the hotspot-dev mailing list