RFR: 8284849: Add deoptimization to unified logging [v11]
Kim Barrett
kbarrett at openjdk.java.net
Wed Jun 15 00:58:50 UTC 2022
On Mon, 23 May 2022 07:22:10 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Johan Sjölén has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Revert my changes to deoptimization.hpp
>> - Declare log_deopt static
>
> src/hotspot/share/runtime/deoptimization.cpp line 1937:
>
>> 1935: if(Log(deoptimization)::is_info()) {
>> 1936: LogMessage(deoptimization) lm;
>> 1937: auto tm = trap_method();
>
> Not sure use if C++11 type inference is a permitted use - I can't find it n the style guide.
[not a review, just responding to @dholmes-ora question]
Search for "Type Deduction" in the style guide. There aren't a lot of uses, and the guidance is to only use it when there's significant benefit, not just as a convenience to avoid writing the type.
-------------
PR: https://git.openjdk.org/jdk/pull/8812
More information about the hotspot-dev
mailing list