RFR: 8288623: Move Continuation classes out of javaClasses.hpp [v4]

Coleen Phillimore coleenp at openjdk.org
Tue Jun 21 11:59:38 UTC 2022


On Tue, 21 Jun 2022 05:38:09 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> javaClasses.hpp is getting too big - it contains the C++ representation of over 50 Java classes.
>> 
>> The RFE moves the following classes into a new file, continuationJavaClasses.hpp. The naming follows the same pattern as the existing header share/jvmci/jvmciJavaClasses.hpp.
>> 
>> - jdk_internal_vm_ContinuationScope
>> - jdk_internal_vm_Continuation
>> - jdk_internal_vm_StackChunk
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @stefank review comments

I like this split very much.  JavaClasses was getting too unwieldy. I'm ambivalent whether continuationJavaClasses.cpp/hpp should go in the runtime directory, so please take Stefan's recommendation and move it there.  Tnanks.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9191


More information about the hotspot-dev mailing list