RFR: 8288623: Move Continuation classes out of javaClasses.hpp [v5]

[Stefan Karlsson]

On Tue, 21 Jun 2022 19:56:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> javaClasses.hpp is getting too big - it contains the C++ representation of over 50 Java classes.
>> 
>> The RFE moves the following classes into a new file, continuationJavaClasses.hpp. The naming follows the same pattern as the existing header share/jvmci/jvmciJavaClasses.hpp.
>> 
>> - jdk_internal_vm_ContinuationScope
>> - jdk_internal_vm_Continuation
>> - jdk_internal_vm_StackChunk
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   moved to runtime/continuationJavaClasses.hpp

I started to add comments to the PR, but then realized it would be easier to just provide a patch with my suggestions. Please take a look at:
https://urldefense.com/v3/__https://github.com/stefank/jdk/tree/pr_9191__;!!ACWV5N9M2RV99hQ!OI4KOm69b7ILJr6be1-p_qpFme84ViIOfZNpCKbQdy8CrsqYt9FfImq-I-J7sSBntHWNpiXB3JdL5Y8P4npwgCk$ 

src/hotspot/share/classfile/continuationJavaClasses.inline.hpp line 32:

> 30: #include "oops/access.inline.hpp"
> 31: #include "oops/stackChunkOop.inline.hpp"
> 32: #include "runtime/continuationJavaClasses.hpp"

The .inline.hpp files should include the corresponding .hpp file as the first included file. This is a fairly recently addition to the style guide, that we did to resolve the compilation problems with circular dependencies between the .inline.hpp files. So, please change this to:

#include "runtime/continuationJavaClasses.hpp"

#include "classfile/javaClasses.hpp"
#include "logging/log.hpp"
#include "oops/access.inline.hpp"
#include "oops/stackChunkOop.inline.hpp"

src/hotspot/share/classfile/javaClasses.inline.hpp line 220:

> 218: }
> 219: #endif // INCLUDE_JFR
> 220: 

Spurious newline

src/hotspot/share/classfile/javaClassesImpl.hpp line 64:

> 62:   JavaClasses::compute_offset(offset, klass, name, vmSymbols::signature(), is_static)
> 63: 
> 64: 

spurious newline

src/hotspot/share/runtime/continuationJavaClasses.cpp line 26:

> 24: 
> 25: #include "precompiled.hpp"
> 26: #include "classfile/javaClasses.hpp"

Why is classfile/javaClasses.hpp included in this file?

src/hotspot/share/runtime/continuationJavaClasses.hpp line 26:

> 24: 
> 25: #ifndef SHARE_CLASSFILE_CONTINUATIONJAVACLASSES_HPP
> 26: #define SHARE_CLASSFILE_CONTINUATIONJAVACLASSES_HPP

Include guard needs to be updated.

src/hotspot/share/runtime/continuationJavaClasses.hpp line 29:

> 27: 
> 28: #include "memory/allStatic.hpp"
> 29: #include "oops/oop.hpp"

oop isn't used in this function, include oopsHierarchy.hpp instead. This file should also include globalDefinitions.hpp and macros.hpp

-------------

Changes requested by stefank (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9191