RFR: JDK-8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes

Thomas Stuefe stuefe at openjdk.org
Thu Jun 23 03:59:54 UTC 2022


On Wed, 22 Jun 2022 16:50:18 GMT, Xin Liu <xliu at openjdk.org> wrote:

> I take a look at linux_arm directory. All functions come in pair(.global and .type function). so it's reasonable. LGTM. I am not a reviewer. we still need other reviewer to approve it.

Thank you, Xin!

> By adding this .type directive, the compiler knows that SafeFetch32_impl is a function. When static linker resolves it, it will update the correct branch instruction according to its target. In this case, it will use BX on Ubuntu18.04.
> 
> Is my understanding correct?

Correct.

-------------

PR: https://git.openjdk.org/jdk/pull/9213


More information about the hotspot-dev mailing list