RFR: 8289006: Cleanup from thread.hpp split [v2]

Coleen Phillimore coleenp at openjdk.org
Thu Jun 23 12:30:44 UTC 2022


On Thu, 23 Jun 2022 06:28:03 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove redundant include
>
> src/hotspot/cpu/zero/stack_zero.cpp line 32:
> 
>> 30: #include "runtime/javaThread.inline.hpp"
>> 31: #include "stack_zero.hpp"
>> 32: #include "stack_zero.inline.hpp"
> 
> Existing, but it is redundant to include the .hpp and the .inline.hpp file as the later always includes the former.

You're right.  I touched that line but didn't even see it.  I confirmed stack_zero.inline.hpp includes stack_zero.hpp, so removed the latter from stack_zero.cpp.  We'll let GHA confirm.

-------------

PR: https://git.openjdk.org/jdk/pull/9252


More information about the hotspot-dev mailing list