[jdk19] RFR: 8288949: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing [v2]

[Coleen Phillimore]

On Sat, 25 Jun 2022 01:19:10 GMT, Ron Pressler <rpressler at openjdk.org> wrote:

>> src/hotspot/share/runtime/mutexLocker.cpp line 287:
>> 
>>> 285:   def(JfieldIdCreation_lock        , PaddedMutex  , safepoint);
>>> 286: 
>>> 287:   def(CompiledIC_lock              , PaddedMutex  , nosafepoint-1);  // locks VtableStubs_lock, InlineCacheBuffer_lock
>> 
>> Please explain.  Is there another lock causing problems?
>
> The handshake lock, which is also nosafepoint.

This should be ok, provided all the tests have been run.

It reduces the rank of other locks, but there's still room in the lock rank range (by 1), and there's an assert for that.
  // These locks have relative rankings, and inherit safepoint checking attributes from that rank.
  defl(InlineCacheBuffer_lock      , PaddedMutex  , CompiledIC_lock);
  defl(VtableStubs_lock            , PaddedMutex  , CompiledIC_lock);  // Also holds DumpTimeTable_lock
  defl(CodeCache_lock              , PaddedMonitor, VtableStubs_lock);
  defl(CompiledMethod_lock         , PaddedMutex  , CodeCache_lock);
  defl(CodeSweeper_lock            , PaddedMonitor, CompiledMethod_lock);

-------------

PR: https://git.openjdk.org/jdk19/pull/66