RFR: 8288971: AArch64: Clean up stack and register handling in interpreter [v2]
Andrew Dinn
adinn at openjdk.org
Thu Jun 30 10:04:39 UTC 2022
On Thu, 30 Jun 2022 09:47:15 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> There are several places in the interpreter that could be improved.
>>
>> 1. We use r13 to pass the caller's SP to a callee through adapters. r13 is not a callee-saved register in the native ABI, so this causes some complications. Use a callee-saved register.
>> 2. We frequently recalculate the location where the native SP needs to go. We have a spare slot in the interpreter frame, so we should calculate it once, when the frame is created, and use it.
>> 3. Related to 1, we should clearly label all the places where the caller's SP is passed to a callee.
>
> Andrew Haley has updated the pull request incrementally with two additional commits since the last revision:
>
> - 8288971: AArch64: Clean up stack and register handling in interpreter
> - 8288971: AArch64: Clean up stack and register handling in interpreter
All good.
-------------
Marked as reviewed by adinn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9239
More information about the hotspot-dev
mailing list