RFR: 8279573: compiler/codecache/CodeCacheFullCountTest.java fails with "RuntimeException: the value of full_count is wrong." [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Tue Mar 1 15:24:04 UTC 2022
On Mon, 28 Feb 2022 16:26:35 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This change adds a conditional to make -XX:-UseCodeCacheFlushing not flush the code cache so that the test passes on loom. It also makes full_count atomic so that the test in codeCache for printing is correct. This change also fixes the test because the full_count field and the message printing are not synchronized, so you can get 2 or more depending on the number of compiler threads.
>> Tested with tier1-3 on linux and windows x64.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> I misunderstood the UseCodeCacheFlushing flag and make it act like MethodFlushing, which is a whole different flag. Using MethodFlushing instead in the test makes it pass on loom and mainline.
Thanks Erik and Tobias. Yes, I could add the other flag and do a retest.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7629
More information about the hotspot-dev
mailing list