RFR: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint

[coleen.phillimore at oracle.com]

On 3/1/22 4:29 PM, David Holmes wrote:
> On Tue, 1 Mar 2022 20:50:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>
>> In Loom, when using -Xint, the +SegmentedCodeCache option cannot be used because it doesn't generate a code heap for nmethods, and in loom the compiler needs to generate an nmethod for Continuation.enterSpecial even with -Xint.
>> This change is @rickard 's loom change with the tests fixed so they pass for it.  One tests for the new warning message and code cache usage, and the others remove the Xint tests.
>> Tested with tier1-4.
> src/hotspot/share/runtime/arguments.cpp line 4122:
>
>> 4120:       FLAG_SET_DEFAULT(SegmentedCodeCache, false);
>> 4121:     }
>> 4122:   }
> Isn't this better placed in Arguments::set_mode_flags where the other compiler related flags get turned off?

Well, the default for SegmentedCodeCache is off.  It's set here because 
it's after that option is found on the command line.  Maybe the line 
should be

if (FLAG_IS_CMDLINE(SegmentedCodeCache)) {
}

to make it more clear.

Coleen
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/7650