RFR: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint

[Coleen Phillimore]

On Tue, 1 Mar 2022 22:20:07 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 4122:
>> 
>>> 4120:       FLAG_SET_DEFAULT(SegmentedCodeCache, false);
>>> 4121:     }
>>> 4122:   }
>> 
>> Isn't this better placed in Arguments::set_mode_flags where the other compiler related flags get turned off?
>
> `SegmentedCodeCache` should be set in `compiler/compilerDefinitions.cpp`:
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compilerDefinitions.cpp#L294

I replied on email but I don't see it and this is better here.  I should really change this to be:

if (FLAG_IS_CMDLINE(SegmentedCodeCache)) {
}
Since this code is checking for someone setting it on the command line with -Xint.  The code in compilerDefinitions.cpp sets the flag ergonomically if the code cache is big and if tiered compilation is on.  I believe this is after the code in arguments.cpp.  So this code won't reset it to true, if I'm following it right.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7650