RFR: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint
Coleen Phillimore
coleenp at openjdk.java.net
Tue Mar 1 23:38:06 UTC 2022
On Tue, 1 Mar 2022 23:20:24 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> I agree that the warning should be issued if flag is set on command line together with `-Xint`.
>> In this case you need add this check to `CompilerConfig::check_args_consistency()` where different compiler flags are set to false when we run with Interpreter:
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compilerDefinitions.cpp#L493
>
> Thanks Coleen, seems the use of `set_mode_flags` is somewhat flawed as you can change any of the flags that it tries to force on/off simply by having them later on the command-line.
>
> You could do as @vnkozlov suggests and move this check into `compilerDefinitions.cpp` as `CompilerConfig::ergo_initialize()` is called just a few lines above this.
Thanks Vladimir, that's a better place for it. There are other checks for inconsistent flags with -Xint in check_args_consistency(). One of the tests still fails with that change so I'll have to figure out why.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7650
More information about the hotspot-dev
mailing list