RFR: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint [v2]

David Holmes dholmes at openjdk.java.net
Wed Mar 2 02:27:06 UTC 2022


On Wed, 2 Mar 2022 02:03:46 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> In Loom, when using -Xint, the +SegmentedCodeCache option cannot be used because it doesn't generate a code heap for nmethods, and in loom the compiler needs to generate an nmethod for Continuation.enterSpecial even with -Xint.
>> This change is @rickard 's loom change with the tests fixed so they pass for it.  One tests for the new warning message and code cache usage, and the others remove the Xint tests.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move check for -Xint.

src/hotspot/share/compiler/compilerDefinitions.cpp line 528:

> 526:   // TieredStopAtLevel==0 allocates nmethod space in the code heap with
> 527:   // SegmentedCodeCache so only disallow the option for -Xint.
> 528:   if (Arguments::is_interpreter_only() && FLAG_IS_CMDLINE(SegmentedCodeCache)) {

You need to check `SegmentedCodeCache==true` else you will generate the warning if someone is explicitly turning it off in combination with `-Xint`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7650


More information about the hotspot-dev mailing list