RFR: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint [v2]

[Vladimir Kozlov]

On Wed, 2 Mar 2022 02:46:25 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/compiler/compilerDefinitions.cpp line 528:
>> 
>>> 526:   // TieredStopAtLevel==0 allocates nmethod space in the code heap with
>>> 527:   // SegmentedCodeCache so only disallow the option for -Xint.
>>> 528:   if (Arguments::is_interpreter_only() && FLAG_IS_CMDLINE(SegmentedCodeCache)) {
>> 
>> You need to check `SegmentedCodeCache==true` else you will generate the warning if someone is explicitly turning it off in combination with `-Xint`.
>
> Yes, code should follow pattern in previous lines:
> 
>     if (SegmentedCodeCache) {
>       if (!FLAG_IS_DEFAULT(SegmentedCodeCache)) {
>         warning("SegmentedCodeCache has no meaningful effect with -Xint");
>       }
>       FLAG_SET_CMDLINE(SegmentedCodeCache, false);
>     }

And you should include it in previous scope which checks `if (Arguments::is_interpreter_only())`

-------------

PR: https://git.openjdk.java.net/jdk/pull/7650