RFR: 8282241: Invalid generic signature for redefined classes [v2]
Alex Menkov
amenkov at openjdk.java.net
Fri Mar 4 17:12:52 UTC 2022
On Thu, 3 Mar 2022 22:51:18 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reworked the test
>
> test/jdk/java/lang/instrument/RetransformGenericSignatureTest.java line 1:
>
>> 1: /*
>
> Can you write this test in the framework where the newer RedefineClasses test are in test/hotspot/jtreg/serviceability/jvmti/RedefineClasses ? You can just write the new class as a string that the inMemory compiler compiles for you. It's a lot simpler and doesn't use a shell script at all.
Reworked the test:
- used in-memory compirer and asm to prepare new version of the class;
- used redefineClass instead of retransformClasses (ClassFileTransformer is not needed anymore);
- used RedefineClassHelper agent instead of the agent from ATransformerManagementTestCase framework;
- moved the test to test/hotspot/jtreg/serviceability/jvmti/RedefineClasses as actually it tests JVMTI functionality.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7676
More information about the hotspot-dev
mailing list