RFR: 8282224: Correct TIG::bang_stack_shadow_pages comments
Coleen Phillimore
coleenp at openjdk.java.net
Mon Mar 7 14:06:01 UTC 2022
On Tue, 22 Feb 2022 06:54:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> When reviewing the RISC-V port of the change, I noticed the comment in the x86 code is worded incorrectly:
>
>
> // Record a new watermark, unless the update is above the safe limit.
> __ cmpptr(rsp, Address(thread, JavaThread::shadow_zone_safe_limit()));
> __ jccb(Assembler::belowEqual, L_done);
>
>
> Stacks grow downwards, so we are recording a new watermark *when* update is above the safe limit.
Yes, now comment matches the code. This looks good, can be checked in as trivial.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7569
More information about the hotspot-dev
mailing list