Integrated: 8282224: Correct TIG::bang_stack_shadow_pages comments
Aleksey Shipilev
shade at openjdk.java.net
Mon Mar 7 15:27:09 UTC 2022
On Tue, 22 Feb 2022 06:54:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> When reviewing the RISC-V port of the change, I noticed the comment in the x86 code is worded incorrectly:
>
>
> // Record a new watermark, unless the update is above the safe limit.
> __ cmpptr(rsp, Address(thread, JavaThread::shadow_zone_safe_limit()));
> __ jccb(Assembler::belowEqual, L_done);
>
>
> Stacks grow downwards, so we are recording a new watermark *when* update is above the safe limit.
This pull request has now been integrated.
Changeset: 8e70f4c3
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/8e70f4c3dca4cefe813c5b0fd39c386230ca2fd7
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
8282224: Correct TIG::bang_stack_shadow_pages comments
Reviewed-by: coleenp
-------------
PR: https://git.openjdk.java.net/jdk/pull/7569
More information about the hotspot-dev
mailing list