RFR: 8282721: HotSpot Style Guide should allow considered use of C++ thread_local [v2]
Daniel D.Daugherty
dcubed at openjdk.java.net
Tue Mar 8 21:22:08 UTC 2022
On Tue, 8 Mar 2022 05:19:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Style guide changes to support JDK-8282469 (PR https://github.com/openjdk/jdk/pull/7719). We no longer prohibit use of C++ `thread_local`, but allow it when there is an essential, and considered, need.
>>
>> This is a modification of the Style Guide, so rough consensus among the HotSpot Group members is required to make this change. Only Group members should vote for approval (via the github PR), though reasoned objections or comments from anyone will be considered. A decision on this proposal will not be made before Friday 18-Mar-2022 at 12h00 UTC.
>>
>> Since we're piggybacking on github PRs here, please use the PR review process to approve (click on Review Changes > Approve), rather than sending a "vote: yes" email reply that would be normal for a CFV.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> Feedback from kbarrett and jrose.
The white space changes threw me for a minute and then I
remembered to review the content changes via .md file and
not via the .html file...
Thumbs up.
-------------
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7720
More information about the hotspot-dev
mailing list