RFR: 8283056: show abstract machine code for all VM crashes

[David Holmes]

On Fri, 11 Mar 2022 20:48:06 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> [JDK-8272586](https://bugs.openjdk.java.net/browse/JDK-8272586) added abstract assembly to hs-err for methods on the stack of the crashing thread. However, it only does this if the crash is due to an unhandled signal. It can also be useful to see assembly for crashes due to failing VM assertions or guarantees. This PR implements this improvement.

Hi Doug,

I'm approving in principle but would like to see the code tweaked as per the comment below.

Thanks,
David

src/hotspot/share/utilities/vmError.cpp line 915:

> 913:      if (_verbose) {
> 914:        frame fr = _context ? os::fetch_frame_from_context(_context)
> 915:                            : os::current_frame();

This seems like it is only need in the else branch at L931, so I'd prefer to see it there please.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7791