RFR: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access [v15]

Martin Doerr mdoerr at openjdk.java.net
Mon Mar 21 13:39:34 UTC 2022


On Mon, 21 Mar 2022 12:13:14 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> This PR introduces a new method `can_access_link` into the frame class to check the accessibility of the link information. It furthermore adds a new `os::is_first_C_frame(frame*, Thread*)` that uses the `can_access_link` method
>> and the passed thread object to check the validity of frame pointer, stack pointer, sender frame pointer and sender stack pointer. This should reduce the possibilities for crashes.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix minor style issues

LGTM. Thanks!

-------------

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7591


More information about the hotspot-dev mailing list