RFR: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access [v15]

[David Holmes]

On Tue, 22 Mar 2022 01:55:22 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix minor style issues
>
> src/hotspot/share/runtime/os.cpp line 1183:
> 
>> 1181: // Looks like all platforms can use the same function to check if C
>> 1182: // stack is walkable beyond current frame.
>> 1183: // Returns true if this is not the case, i.e. the frame is possibly
> 
> This comment sounds wrong. Surely we return true if it is the case that the given frame is the first C frame on the stack?

Never mind I see the full context now. Would have been better to not start this comment on a new line in the original code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7591