RFR: 8263134: HotSpot Style Guide should disallow inheriting constructors [v2]

Kim Barrett kbarrett at openjdk.java.net
Sat Mar 26 21:50:37 UTC 2022


> Please review this change to explicitly disallow the use of inheriting
> constructors:
> (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2540.htm).
> 
> The C++11/14 specification has a lot of problems. These were addressed in
> C++17 (and as a DR that affects C++11/14):
> (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/p0136r1.html).
> 
> Use of inheriting constructors now runs the risk of encountering those bugs,
> inconsistent behavior between different compilers or compiler versions, and
> behavior changes for future support of C++17.
> 
> This is a modification of the Style Guide, so rough consensus among the
> HotSpot Group members is required to make this change. Only Group members
> should vote for approval (via the github PR), though reasoned objections or
> comments from anyone will be considered. A decision on this proposal will not
> be made before Friday 18-Mar-2022 at 12h00 UTC.
> 
> Since we're piggybacking on github PRs here, please use the PR review process
> to approve (click on Review Changes > Approve), rather than sending a "vote:
> yes" email reply that would be normal for a CFV.

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into no_inherited_ctors
 - update html
 - forbid inherited ctors

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7698/files
  - new: https://git.openjdk.java.net/jdk/pull/7698/files/3e2be799..eddebb35

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7698&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7698&range=00-01

  Stats: 130513 lines in 1875 files changed: 96087 ins; 28343 del; 6083 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7698.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7698/head:pull/7698

PR: https://git.openjdk.java.net/jdk/pull/7698


More information about the hotspot-dev mailing list