RFR: 8283013: Simplify Arguments::parse_argument() [v2]

David Holmes dholmes at openjdk.java.net
Mon Mar 28 22:37:45 UTC 2022


On Mon, 28 Mar 2022 20:56:08 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> - Remove all the complex `sscanf()` calls in `Arguments::parse_argument()`
>> - Call the appropriate parsing function according to the type of the flag
>> - Added more test cases for flags of the `double` type.
>> 
>> As a result of this change, `double` flags can now be specified in more ways, as long as the input is accepted by `strtod()`. However, `NaN` and `INFINITY` values are not allowed because the VM probably cannot handle them. Please see the test case for details.
>> 
>> Tested with tiers 1-5.
>
> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Disabled test for CompileThresholdScaling due to JDK-8283807
>  - @dholmes-ora comments

Thanks for the update. One nit.

David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7916


More information about the hotspot-dev mailing list