RFR: 8283013: Simplify Arguments::parse_argument() [v3]

Ioi Lam iklam at openjdk.java.net
Tue Mar 29 05:41:19 UTC 2022


> - Remove all the complex `sscanf()` calls in `Arguments::parse_argument()`
> - Call the appropriate parsing function according to the type of the flag
> - Added more test cases for flags of the `double` type.
> 
> As a result of this change, `double` flags can now be specified in more ways, as long as the input is accepted by `strtod()`. However, `NaN` and `INFINITY` values are not allowed because the VM probably cannot handle them. Please see the test case for details.
> 
> Tested with tiers 1-5.

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  moved comment

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7916/files
  - new: https://git.openjdk.java.net/jdk/pull/7916/files/0faa4cca..6fb2ccef

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7916&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7916&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7916.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7916/head:pull/7916

PR: https://git.openjdk.java.net/jdk/pull/7916


More information about the hotspot-dev mailing list