RFR: 8283013: Simplify Arguments::parse_argument() [v4]

Ioi Lam iklam at openjdk.java.net
Wed Mar 30 20:39:16 UTC 2022


> - Remove all the complex `sscanf()` calls in `Arguments::parse_argument()`
> - Call the appropriate parsing function according to the type of the flag
> - Added more test cases for flags of the `double` type.
> 
> As a result of this change, `double` flags can now be specified in more ways, as long as the input is accepted by `strtod()`. However, `NaN` and `INFINITY` values are not allowed because the VM probably cannot handle them. Please see the test case for details.
> 
> Tested with tiers 1-5.

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  @calvinccheung comment: check for zero-length flag name

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7916/files
  - new: https://git.openjdk.java.net/jdk/pull/7916/files/6fb2ccef..3f1f28f7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7916&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7916&range=02-03

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7916.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7916/head:pull/7916

PR: https://git.openjdk.java.net/jdk/pull/7916


More information about the hotspot-dev mailing list