RFR: 8283849: AsyncGetCallTrace may crash JVM on guarantee [v2]

[Jaroslav Bachorik]

On Tue, 3 May 2022 01:29:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>
> src/hotspot/cpu/ppc/frame_ppc.inline.hpp line 39:
> 
>> 37:   assert(pc != NULL, "precondition: must have PC");
>> 38: 
>> 39:   if (!forSignalHandler) {
> 
> To reduce the duplication I suggest adding a helper method to CodeCache:
> 
> CodeBlob* find_blob(address pc, bool for_signal_handler) {
>   if (!for_signal_handler) {
>     return find_blob(pc);
>   } else {
>     CodeBlob* tmp = find_blob_unsafe(pc);
>     if (tmp != NULL && temp->is_zombie()) {
>       tmp = null;
>     }
>     return tmp;
> }

Done

-------------

PR: https://git.openjdk.java.net/jdk/pull/8061